Skip to content

fix: resolve 2 bugs - #3345

Closed
saurabhhhcodes wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-36892
Closed

fix: resolve 2 bugs#3345
saurabhhhcodes wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-36892

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes real bugs found in the codebase:

  • Added null-safety guard: .map() on an undefined collection threw TypeError; now falls back to [].
  • Added null-safety guard: .map() on an undefined collection threw TypeError; now falls back to [].

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #3348

@github-actions github-actions Bot added type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:design GSSoC type bonus: UI/design (+10 pts) type:performance GSSoC type bonus: performance (+15 pts) gssoc26 GSSoC 2026 contribution labels Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@saurabhhhcodes saurabhhhcodes changed the title fix: code quality and safety improvements fix: resolve 2 bugs Aug 2, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder added the gssoc:spam GSSoC: Spam contribution label Aug 6, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Closing as a duplicate. The valid part of this change (isNaNNumber.isNaN, ?? [] guards) has been consolidated and merged in #3332, which covers the same cleanup in a single PR.

This exact change was opened 2–3 times under different numbers. Please open one PR per change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:spam GSSoC: Spam contribution gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants